feat: add resource dataproc jobs controller #4231
Conversation
xiaoweim
force-pushed
the
resource-dataproc-jobs
branch
from
91d6f4e to
4fd51ce
Compare
xiaoweim
changed the title
xiaoweim
force-pushed
the
resource-dataproc-jobs
branch
3 times, most recently
from
f595c8a to
f64b6a6
Compare
...c/v1alpha1/dataprocjob/dataprocjob-minimal/_generated_object_dataprocjob-minimal.golden.yaml
Outdated
Show resolved
Hide resolved
...t/resourcefixture/testdata/basic/dataproc/v1alpha1/dataprocjob/dataprocjob-minimal/_http.log
Show resolved
Hide resolved
xiaoweim
force-pushed
the
resource-dataproc-jobs
branch
5 times, most recently
from
5e20145 to
3ab15cb
Compare
|
Thanks! Could you share the new git-diff between real and mock? |
Sure, I can record it again. |
xiaoweim
force-pushed
the
resource-dataproc-jobs
branch
from
3ab15cb to
b6bc8c3
Compare
If you referring to the changes in controller to add the server-generated id, I have added that manually. |
|
/assign @jingyih Could you please take a look at this PR? |
| @@ -34,6 +34,21 @@ func redisClusterFuzzer() fuzztesting.KRMFuzzer { | |||
| ) | |||
|
|
|||
| f.UnimplementedFields.Insert(".name") // Identifier | |||
| f.UnimplementedFields.Insert(".backup_collection") | |||
There was a problem hiding this comment.
These "UnimplementedFields" were already added in this file?
There was a problem hiding this comment.
No, the go dependency was updated and the updated proto has these fields but KCC currently do not support.
...resourcefixture/testdata/basic/dataproc/v1alpha1/dataprocjob/dataprocjob-minimal/update.yaml
Outdated
Show resolved
Hide resolved
xiaoweim
force-pushed
the
resource-dataproc-jobs
branch
from
84f4efd to
ffb8e28
Compare
| Labels: desiredProto.Labels, | ||
| } | ||
| // Populate the job type specific field | ||
| if a.desired.Spec.HadoopJob != nil { |
There was a problem hiding this comment.
I am a bit confused. These conversion should be handled by mapping functions? I would expect DataprocJobSpec_ToProto to handle this.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingyih The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit de268fd
into
GoogleCloudPlatform:master
make ready-prto ensure this PR is ready for review.